Invert use of macro_can_be_placed argument in check_all_legality #2998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
gigeresk
force-pushed
the
fredt_check_all_legality_flip
branch
from
bdc8c45 to
08c1809
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of the check_all_legality function parameter was the inverse of what was documented.
Description
The check_all_legality parameter performs additional legality checks regarding macro placement.
Invert the use of the value and the value itself in most cases. Some uses are unchanged because they were initially incorrect.
Related Issue
None
Motivation and Context
Improves code clarity and reverts to expected behaviour.
How Has This Been Tested?
TODO: run qor and test suite
Types of changes
Checklist: